sashapolo commented on code in PR #6753:
URL: https://github.com/apache/ignite-3/pull/6753#discussion_r2439907945
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentPayload.java:
##########
@@ -61,6 +70,21 @@ static void writeTo(
buffer.putInt(crc);
}
+ static void writeTruncateSuffixRecordTo(ByteBuffer buffer, long groupId,
long lastLogIndexKept) {
+ int originalPos = buffer.position();
+
+ buffer
+ .putLong(groupId)
Review Comment:
> You use buffer, not buffer()
Can you please point me to it? I don't understand...
> Anyway, how do you guarantee that it's little endian?
In this class I do not guarantee it. This class' task is to write payload
into the provided buffer, it should not care about its endianness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
