shishkovilja commented on code in PR #12347: URL: https://github.com/apache/ignite/pull/12347#discussion_r2407891512
########## docs/_docs/perf-and-troubleshooting/memory-tuning.adoc: ########## @@ -122,10 +122,8 @@ Note that 10GB heap is used as an example and a smaller heap can be enough for y [NOTE] ==== -//TODO: Is this still valid? What does it do? -If you use link:persistence/native-persistence[Ignite native persistence], we recommend that you set the -`MaxDirectMemorySize` JVM parameter to `walSegmentSize * 4`. -With the default WAL settings, this value is equal to 256MB. +If you use link:persistence/native-persistence[Ignite native persistence], we recommend relying on the JVM default for direct memory. By default, the JVM allows direct buffers grow up to the Java heap size (-Xmx), which is sufficient in most cases. Review Comment: ```suggestion If you use link:persistence/native-persistence[Ignite native persistence], we recommend relying on the JVM default configuration of direct memory. By default, the JVM allows direct buffers grow up to the Java heap size (-Xmx), which is sufficient in most cases. ``` ########## docs/_docs/perf-and-troubleshooting/memory-tuning.adoc: ########## @@ -122,10 +122,8 @@ Note that 10GB heap is used as an example and a smaller heap can be enough for y [NOTE] ==== -//TODO: Is this still valid? What does it do? -If you use link:persistence/native-persistence[Ignite native persistence], we recommend that you set the -`MaxDirectMemorySize` JVM parameter to `walSegmentSize * 4`. -With the default WAL settings, this value is equal to 256MB. +If you use link:persistence/native-persistence[Ignite native persistence], we recommend relying on the JVM default for direct memory. By default, the JVM allows direct buffers grow up to the Java heap size (-Xmx), which is sufficient in most cases. +If you need an explicit limit, set `-XX:MaxDirectMemorySize` to at least `walSegmentSize * 4` (256 MB with the default WAL settings). Review Comment: ```suggestion If you need to override default limit for direct memory size, you should set `-XX:MaxDirectMemorySize` to at least `walSegmentSize * 4` (256 MB with the default WAL settings). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
