korlov42 commented on code in PR #6648: URL: https://github.com/apache/ignite-3/pull/6648#discussion_r2381979644
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/UpdateTable.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog.storage; + +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.defaultZoneIdOpt; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceSchema; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.replaceTable; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.schemaOrThrow; +import static org.apache.ignite.internal.catalog.commands.CatalogUtils.tableOrThrow; + +import org.apache.ignite.internal.catalog.Catalog; +import org.apache.ignite.internal.catalog.descriptors.CatalogSchemaDescriptor; +import org.apache.ignite.internal.catalog.descriptors.CatalogTableDescriptor; +import org.apache.ignite.internal.hlc.HybridTimestamp; + +/** Interface describing a particular change to a table within the {@link VersionedUpdate group}. */ +interface UpdateTable extends UpdateEntry { + @Override + default Catalog applyUpdate(Catalog catalog, HybridTimestamp timestamp) { + CatalogTableDescriptor table = tableOrThrow(catalog, tableId()); + CatalogSchemaDescriptor schema = schemaOrThrow(catalog, table.schemaId()); + + CatalogTableDescriptor modifiedTable = newTableDescriptor(table) + .tableVersion(newTableVersion(table)) Review Comment: that's not correct for a generic `UpdateTable` handler. Version should be bumped only when table's schema (e.g. table's columns) is modified somehow ########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogTableDescriptor.java: ########## @@ -282,4 +250,199 @@ public String storageProfile() { return storageProfile; } + /** + * {@code CatalogTableDescriptor} builder static inner class. + */ + public static final class Builder { + private int id; + private String name; + private int zoneId; + private int schemaId; + private int pkIndexId; + private CatalogTableSchemaVersions schemaVersions; + private List<CatalogTableColumnDescriptor> columns; + private List<String> primaryKeyColumns; + @Nullable private List<String> colocationColumns; + private String storageProfile; + private HybridTimestamp timestamp = INITIAL_TIMESTAMP; + private int tableVersion = 0; Review Comment: why do we need explicit field for `tableVersion`? It's always been representing version of the table row, not the table itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
