sashapolo commented on code in PR #6777:
URL: https://github.com/apache/ignite-3/pull/6777#discussion_r2432409778
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/IndexMemTable.java:
##########
@@ -44,16 +44,24 @@ public void appendSegmentFileOffset(long groupId, long
logIndex, int segmentFile
// File offset can be less than 0 (it's treated as an unsigned
integer) but never 0, because of the file header.
assert segmentFileOffset != 0 : String.format("Segment file offset
must not be 0 [groupId=%d]", groupId);
- SegmentInfo segmentInfo =
stripe(groupId).memTable.computeIfAbsent(groupId, id -> new
SegmentInfo(logIndex));
+ ConcurrentMap<Long, SegmentInfo> memTable = stripe(groupId).memTable;
- segmentInfo.addOffset(logIndex, segmentFileOffset);
+ SegmentInfo segmentInfo = memTable.get(groupId);
+
+ if (segmentInfo == null) {
+ segmentInfo = new SegmentInfo(logIndex);
+
+ segmentInfo.addOffset(logIndex, segmentFileOffset);
+
+ memTable.put(groupId, segmentInfo);
Review Comment:
no, we have one writing thread per group ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
