Pochatkin commented on code in PR #6687:
URL: https://github.com/apache/ignite-3/pull/6687#discussion_r2413517115
##########
modules/api/src/main/java/org/apache/ignite/table/mapper/MapperBuilder.java:
##########
@@ -289,10 +293,10 @@ private static SimpleEntry<String, String>
getColumnToFieldMapping(Field fld) {
String fldName = fld.getName();
var column = fld.getAnnotation(Column.class);
if (column == null) {
- return new SimpleEntry<>(fldName, fldName);
+ return new SimpleEntry<>(parseIdentifier(fldName), fldName);
} else {
var columnName = column.value().isEmpty() ? fldName :
column.value();
- return new SimpleEntry<>(columnName, fldName);
+ return new SimpleEntry<>(parseIdentifier(columnName), fldName);
Review Comment:
Done
##########
modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/Marshaller.java:
##########
@@ -56,15 +56,15 @@ static Marshaller createMarshaller(
}
if (mapper.targetType().isPrimitive()) {
- throw new IllegalArgumentException("Mappers for primitive types
are not supported: " + mapper.targetType());
+ throw new MarshallerException("Mappers for primitive types are not
supported: " + mapper.targetType());
}
if (mapper instanceof OneColumnMapper) {
return simpleMarshaller(cols, (OneColumnMapper<?>) mapper);
} else if (mapper instanceof PojoMapper) {
return pojoMarshaller(cols, (PojoMapper<?>) mapper,
requireAllFields, allowUnmappedFields);
} else {
- throw new IllegalArgumentException("Mapper of unsupported type: "
+ mapper.getClass());
+ throw new MarshallerException("Mapper of unsupported type: " +
mapper.getClass());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
