rpuch commented on code in PR #6721:
URL: https://github.com/apache/ignite-3/pull/6721#discussion_r2415778286
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/IgniteCluster.java:
##########
@@ -391,6 +392,13 @@ public List<RunnerNode> getRunnerNodes() {
return runnerNodes;
}
+ /** Returns node's work directory. */
+ public Path workDir(int nodeIndex, boolean embedded) {
Review Comment:
`boolean` parameters in APIs are better to be avoided as the code that calls
them is not that readable: you always wonder what that `true` or `false` means.
Instead, please add 2 methods: `embeddedNodeWorkDir(int)` and
`runnerNodeWorkDir(int)`. They could both use a private `workDir(int, boolean)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
