tkalkirill commented on code in PR #6696:
URL: https://github.com/apache/ignite-3/pull/6696#discussion_r2405998606
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/CliIntegrationTest.java:
##########
@@ -69,6 +69,7 @@ public abstract class CliIntegrationTest extends
ClusterPerClassIntegrationTest
new MetricSource().name("sql.client").enabled(true),
new MetricSource().name("sql.plan.cache").enabled(true),
new MetricSource().name("sql.queries").enabled(true),
+ new MetricSource().name("storage.aipersist").enabled(true),
new MetricSource().name("storage.aipersist.default").enabled(true),
new
MetricSource().name("storage.aipersist.default_aipersist").enabled(true),
new
MetricSource().name("storage.aipersist.checkpoint").enabled(true),
Review Comment:
> For metrics under 'engine + storage profile', we add another level after
the engine, like 'aipersist.profile.default'
I think it should be corrected in another ticket, but I might also need to
submit the documentation.
> We add our own engine metrics right under the engine, like
'aipersist.checkpoint'
I didn't understand what you meant here.
In the current ticket, maybe they should add a metric source like
`storage.aipersist.engine`(which will have
`storage.aipersist.engine.StorageSize` in it?), what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
