valepakh commented on code in PR #6625: URL: https://github.com/apache/ignite-3/pull/6625#discussion_r2378027870
########## modules/code-deployment/src/main/java/org/apache/ignite/internal/deployunit/FilesDeploymentUnit.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.deployunit; + +import static org.apache.ignite.internal.util.IgniteUtils.closeAll; + +import java.io.IOException; +import java.io.InputStream; +import java.util.Map; + +/** + * Standard implementation of {@link DeploymentUnit} that handles regular (non-compressed) deployment content. + * + * <p>This class represents a deployment unit containing a collection of files, where each file is + * represented as a mapping from file name to its corresponding {@link InputStream}. This implementation is designed for straightforward + * deployment scenarios where the content does not require compression or special extraction handling. + * + * <p>The {@code DeploymentUnitImpl} is the primary implementation used for most deployment operations + * in the Apache Ignite code deployment system. It provides a simple and efficient way to package and deploy code artifacts, configuration + * files, resources, and other deployment assets to Ignite cluster nodes. + */ +public class DeploymentUnitImpl implements DeploymentUnit { + /** + * The deployment unit content represented as a mapping from file names to their input streams. Each entry represents a file within the + * deployment unit. + */ + private final Map<String, InputStream> content; + + /** + * Constructor. + */ + public DeploymentUnitImpl(Map<String, InputStream> content) { + this.content = content; + } + + /** + * Returns the deployment unit content as a map of file names to input streams. + */ + public Map<String, InputStream> content() { + return content; + } + + @Override + public void close() throws Exception { + closeAll(content.values()); + } + + @Override + public <T> void process(DeploymentUnitProcessor<T> processor, T arg) throws IOException { + processor.processContent(this, arg); Review Comment: I presume the tar support will simply add a new method to the processor so this inversion will still not be needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
