ibessonov commented on code in PR #6766:
URL: https://github.com/apache/ignite-3/pull/6766#discussion_r2431401493
##########
modules/configuration-storage/src/test/java/org/apache/ignite/internal/configuration/storage/LocalFileConfigurationStorageTest.java:
##########
@@ -545,6 +555,28 @@ void testReadOnly() throws Exception {
assertThat(storage.write(Map.of(), storage.localRevision().get() + 1),
willCompleteSuccessfully());
}
+ @Test
+ void updateAfterRestart() throws Exception {
+ assertThat(configFileContent(), emptyString());
+
+ // Initialize value
+ com.typesafe.config.Config config =
ConfigFactory.parseString("top.polyNamedList =
[{name=name1,strVal=foo,type=first}]");
+ ConfigurationSource source = HoconConverter.hoconSource(config.root());
+
+ changer.start();
+ changer.change(source).join();
Review Comment:
Usually we write something like `assertThat(changer.change(source),
willCompleteSuccessfully())`. Having uninterruptible joins even in tests is a
bad practice, please consider changing this code. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
