denis-chudov commented on code in PR #6651:
URL: https://github.com/apache/ignite-3/pull/6651#discussion_r2411000636
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DataNodesManager.java:
##########
@@ -1100,6 +1164,30 @@ CompletableFuture<?> onZoneCreate(
int zoneId,
HybridTimestamp timestamp,
Set<NodeWithAttributes> dataNodes
+ ) {
+ return initZone(zoneId, timestamp, dataNodes);
+ }
+
+ private CompletableFuture<?>
initZoneWithLegacyDataNodes(CatalogZoneDescriptor zone, byte[]
legacyDataNodesBytes) {
+ Set<NodeWithAttributes> dataNodes =
DataNodesMapSerializer.deserialize(legacyDataNodesBytes).keySet().stream()
+ .map(node -> new NodeWithAttributes(node.nodeName(),
node.nodeId(), null))
Review Comment:
unfortunately we don't have attributes in old data nodes and they are not
needed:
- on topology change we look only on added nodes' attributes
- on filter change we filter topology nodes
- on auto adjust alteration we only modify timers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
