ptupitsyn commented on code in PR #6645:
URL: https://github.com/apache/ignite-3/pull/6645#discussion_r2378669787
##########
modules/client/src/main/java/org/apache/ignite/internal/client/ClientMetricSource.java:
##########
@@ -30,8 +30,8 @@ public class ClientMetricSource extends
AbstractMetricSource<ClientMetricSource.
/**
* Constructor.
*/
- ClientMetricSource() {
- super("client");
+ ClientMetricSource(String name) {
Review Comment:
`makeMbeanName` is invoked for client metrics too. If I set the client name
to "my-client", the resulting bean name is
"org.apache.ignite:type=metrics,name=my-client" - same behavior as on the
server. You can see it in the tests.
Do you think this is wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
