sashapolo commented on code in PR #6804:
URL: https://github.com/apache/ignite-3/pull/6804#discussion_r2439193569
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -352,10 +352,10 @@ public void cancel() {
log.debug("Cancelling grid runnable: " + this);
}
- // Do not interrupt runner thread.
- isCancelled.set(true);
-
synchronized (mux) {
+ // Do not interrupt runner thread.
+ isCancelled.set(true);
Review Comment:
because Spotbugs now complains that we call `notifyAll` on a mutex without
changing the state of the class (IDEA does the same, btw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
