sashapolo commented on code in PR #6815:
URL: https://github.com/apache/ignite-3/pull/6815#discussion_r2445005582


##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -613,6 +613,17 @@ private <R extends NetworkMessage> CompletableFuture<R> 
sendWithRetry(
             Supplier<String> originDescription,
             Function<Peer, ? extends NetworkMessage> requestFactory,
             boolean throttleOnOverload
+    ) {
+        return sendWithRetry(peer, timeoutMillis, -1, originDescription, 
requestFactory, throttleOnOverload);
+    }
+
+    private <R extends NetworkMessage> CompletableFuture<R> sendWithRetry(

Review Comment:
   Please add javadocs about what "-1" means and what is the difference between 
"timeoutMillis" and "responseTimeoutMillis"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to