shishkovilja commented on code in PR #12415:
URL: https://github.com/apache/ignite/pull/12415#discussion_r2449205299
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/QueryBatchAcknowledgeMessage.java:
##########
@@ -17,26 +17,27 @@
package org.apache.ignite.internal.processors.query.calcite.message;
-import java.nio.ByteBuffer;
import java.util.UUID;
-
-import org.apache.ignite.plugin.extensions.communication.MessageReader;
-import org.apache.ignite.plugin.extensions.communication.MessageWriter;
+import org.apache.ignite.internal.Order;
/**
*
*/
public class QueryBatchAcknowledgeMessage implements ExecutionContextAware {
/** */
+ @Order(0)
private UUID queryId;
Review Comment:
```suggestion
private UUID qryId;
```
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/QueryBatchAcknowledgeMessage.java:
##########
@@ -17,26 +17,27 @@
package org.apache.ignite.internal.processors.query.calcite.message;
-import java.nio.ByteBuffer;
import java.util.UUID;
-
-import org.apache.ignite.plugin.extensions.communication.MessageReader;
-import org.apache.ignite.plugin.extensions.communication.MessageWriter;
+import org.apache.ignite.internal.Order;
/**
*
*/
public class QueryBatchAcknowledgeMessage implements ExecutionContextAware {
/** */
+ @Order(0)
Review Comment:
```suggestion
@Order(value = 0, method = "queryId")
```
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/QueryBatchAcknowledgeMessage.java:
##########
@@ -57,106 +58,51 @@ public QueryBatchAcknowledgeMessage(UUID queryId, long
fragmentId, long exchange
return queryId;
}
+ /**
+ * @param queryId New query ID.
+ */
+ public void queryId(UUID queryId) {
+ this.queryId = queryId;
Review Comment:
```suggestion
this.qryId = qryId;
```
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/QueryBatchAcknowledgeMessage.java:
##########
@@ -57,106 +58,51 @@ public QueryBatchAcknowledgeMessage(UUID queryId, long
fragmentId, long exchange
return queryId;
}
+ /**
+ * @param queryId New query ID.
Review Comment:
```suggestion
* @param qryId New query ID.
```
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/message/QueryBatchAcknowledgeMessage.java:
##########
@@ -57,106 +58,51 @@ public QueryBatchAcknowledgeMessage(UUID queryId, long
fragmentId, long exchange
return queryId;
}
+ /**
+ * @param queryId New query ID.
+ */
+ public void queryId(UUID queryId) {
Review Comment:
```suggestion
public void queryId(UUID qryId) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
