sanpwc commented on code in PR #6810:
URL: https://github.com/apache/ignite-3/pull/6810#discussion_r2450654142
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/TransactionStateResolver.java:
##########
@@ -138,6 +141,26 @@ public CompletableFuture<TransactionMeta> resolveTxState(
UUID txId,
ReplicationGroupId commitGrpId,
@Nullable HybridTimestamp timestamp
+ ) {
+ return resolveTxState(txId, commitGrpId, timestamp,
AWAIT_PRIMARY_REPLICA_TIMEOUT, SECONDS);
+ }
+
+ /**
+ * Resolves transaction state locally, if possible, or distributively, if
needed.
+ *
+ * @param txId Transaction id.
+ * @param commitGrpId Commit partition group id.
+ * @param timestamp Timestamp.
+ * @param awaitPrimaryReplicaTimeout Timeout for awaiting primary replica.
+ * @param awaitPrimaryReplicaTimeUnit Time unit for awaiting primary
replica timeout.
+ * @return Future with the transaction state meta as a result.
+ */
+ public CompletableFuture<TransactionMeta> resolveTxState(
+ UUID txId,
+ ReplicationGroupId commitGrpId,
+ @Nullable HybridTimestamp timestamp,
+ long awaitPrimaryReplicaTimeout,
Review Comment:
Within the context of given method, I'd rather name the param as
"awaitCommitPartitionAvailabilityTimeout" or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
