EgorKuts commented on code in PR #6712:
URL: https://github.com/apache/ignite-3/pull/6712#discussion_r2451896532
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogZoneTest.java:
##########
@@ -53,13 +53,21 @@
import org.apache.ignite.internal.catalog.events.CreateZoneEventParameters;
import org.apache.ignite.internal.catalog.events.DropZoneEventParameters;
import org.apache.ignite.internal.event.EventListener;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
/** Tests for zone related commands. */
public class CatalogZoneTest extends BaseCatalogManagerTest {
+ private static final String DEFAULT_ZONE_TABLE = "DEFAULT_ZONE_TABLE";
+
private static final String TEST_ZONE_NAME = "TEST_ZONE_NAME";
+ @BeforeEach
+ public void createTableWithLazyDefaultZone() {
Review Comment:
cleanup aftereach?
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/systemviews/ItZonesSystemViewTest.java:
##########
@@ -49,6 +49,10 @@ public class ItZonesSystemViewTest extends
AbstractSystemViewTest {
@Test
public void systemViewDefaultZone() {
IgniteImpl node = unwrapIgniteImpl(CLUSTER.aliveNode());
+
+ // Table for default zone creation
Review Comment:
maybe add
`assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(0L).check();`
so it's clear that the zone was created during createTableOnly?
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -592,6 +581,10 @@ private static int defaultZoneId(CatalogManager catalog) {
return
catalog.catalog(catalog.latestCatalogVersion()).defaultZone().id();
}
+ private static boolean isDefaultZoneExists(CatalogManager catalog) {
Review Comment:
`isDefaultZoneExists` is a small english mistake. what about
`hasDefaultZone`?
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/systemviews/ItZonesSystemViewTest.java:
##########
@@ -165,22 +169,22 @@ public void systemViewRenameCustomZone() {
DEFAULT_CONSISTENCY_MODE.name()
).check();
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(2L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
sql("DROP ZONE " + ALTER_ZONE_NAME);
}
@Test
public void systemViewDropCustomZone() {
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(0L).check();
sql(createZoneSql(ZONE_NAME, 1, 5, 2, 3, 4, DEFAULT_FILTER));
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(2L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
sql("DROP ZONE " + ZONE_NAME);
- assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(1L).check();
+ assertQuery("SELECT COUNT(*) FROM SYSTEM.ZONES").returns(0L).check();
}
Review Comment:
please also add a test that checks that if a zone default zone is present,
createTable doesn't create additional zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
