xtern commented on code in PR #6806:
URL: https://github.com/apache/ignite-3/pull/6806#discussion_r2452375340
##########
modules/jdbc/src/integrationTest/java/org/apache/ignite/jdbc/ItJdbcMultiStatementSelfTest.java:
##########
@@ -145,18 +146,25 @@ public void testSimpleQueryExecute() throws Exception {
public void testSimpleQueryError() throws Exception {
boolean res = stmt.execute("SELECT 1; SELECT 1/0; SELECT 2");
assertTrue(res);
- assertThrowsSqlException("Failed to fetch query results", () ->
stmt.getMoreResults());
+ assertThrowsSqlException("Division by zero", () ->
stmt.getMoreResults());
// Next after exception.
- assertFalse(stmt.getMoreResults());
+ // assertFalse(stmt.getMoreResults());
+ // Do not move past the first result.
+ assertThrowsSqlException("Division by zero", () ->
stmt.getMoreResults());
stmt.closeOnCompletion();
}
+ @Test
+ public void testSimpleQueryErrorDoNotReleaseResources() throws Exception {
+ stmt.execute("SELECT 1; SELECT 2/0; SELECT 3");
Review Comment:
We have `testSimpleQueryErrorCloseRs` that executes the same query and
reproduces the same issue (that is fixed in `ClientSqlCursorNextResultRequest`
in this PR).
Anyway can we at least rename it to
`testSimpleQueryErrorMustReleaseServerResources` or something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
