lowka commented on code in PR #6838:
URL: https://github.com/apache/ignite-3/pull/6838#discussion_r2454834348
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSqlQueryExecutionMetricsTest.java:
##########
@@ -158,24 +159,20 @@ public void testSingleTimeout() {
);
// Run multiple times to make the test case stable w/o setting large
timeout values.
- Awaitility.await().ignoreExceptions().until(() -> {
- assertMetricIncreased(() ->
assertThrowsSqlException(Sql.EXECUTION_CANCELLED_ERR, "", () -> {
- Statement statement = sql.statementBuilder()
- .query("SELECT * FROM system_range(1,
1000000000000000)")
- .queryTimeout(timeoutSeconds, timeoutUnit)
- .build();
-
- try (ResultSet<SqlRow> rs = sql.execute(null, statement)) {
- timeoutUnit.sleep(timeoutSeconds);
- // Triggers timeout
- while (rs.hasNext()) {
- assertNotNull(rs.next());
- }
+ assertMetricIncreased(() ->
assertThrowsSqlException(Sql.EXECUTION_CANCELLED_ERR, "", () -> {
Review Comment:
The `Awaitility.await().ignoreExceptions().until(..)` thing is done inside
the `assertMetricIncreased` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
