timoninmaxim commented on code in PR #12456:
URL: https://github.com/apache/ignite/pull/12456#discussion_r2460124432
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -778,6 +778,13 @@ private IgniteInternalFuture<SnapshotOperationResponse>
initLocalSnapshotStartSt
if (!CU.baselineNode(cctx.localNode(),
cctx.kernalContext().state().clusterState()))
return new GridFinishedFuture<>();
+ if (log.isInfoEnabled()) {
+ log.info("Starting local snapshot operation [snpName=" +
req.snapshotName() +
Review Comment:
let's log full SnapshotOperationRequest (use GridExcludeString for useless
fields)
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -1236,6 +1243,14 @@ private IgniteInternalFuture<SnapshotOperationResponse>
initLocalSnapshotEndStag
if (snpReq == null || !Objects.equals(req.requestId(),
snpReq.requestId()))
return new GridFinishedFuture<>();
+ if (log.isInfoEnabled()) {
Review Comment:
Let's add log to the reduce phase too
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -1236,6 +1243,14 @@ private IgniteInternalFuture<SnapshotOperationResponse>
initLocalSnapshotEndStag
if (snpReq == null || !Objects.equals(req.requestId(),
snpReq.requestId()))
return new GridFinishedFuture<>();
+ if (log.isInfoEnabled()) {
Review Comment:
Let's write it after prepFut completes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
