shishkovilja commented on code in PR #12431:
URL: https://github.com/apache/ignite/pull/12431#discussion_r2460561528
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/ErrorMessage.java:
##########
@@ -34,14 +36,15 @@
* to transfer some error as part of some message. See {@link
MessageProcessor} for details.
* <p>Currently, under the hood marshalling and unmarshalling is performed by
{@link JdkMarshaller}.
*/
-@SuppressWarnings({"AssignmentOrReturnOfFieldWithMutableType",
"NullableProblems"})
+@SuppressWarnings({"NullableProblems", "unused"})
public class ErrorMessage implements Message {
- /** Serialized form of throwable. */
+ /** Serialization and deserealization methods call holder. Is not uses as
a data holder. */
Review Comment:
```suggestion
/** Serialization and deserealization methods call holder. Is not used
as a data holder. */
```
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/GridDistributedLockResponse.java:
##########
@@ -142,7 +142,7 @@ public void futureId(IgniteUuid futId) {
/** {@inheritDoc} */
@Override public Throwable error() {
- return errMsg != null ? errMsg.toThrowable() : null;
+ return errMsg != null ? errMsg.error() : null;
Review Comment:
```suggestion
return ErrorMessage.error(errMsg);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
