w3ll1ngt commented on code in PR #12436:
URL: https://github.com/apache/ignite/pull/12436#discussion_r2469064676
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicAbstractUpdateRequest.java:
##########
@@ -131,7 +138,7 @@ protected GridDhtAtomicAbstractUpdateRequest(int cacheId,
this.nodeId = nodeId;
this.futId = futId;
this.writeVer = writeVer;
- this.syncMode = syncMode;
+ this.syncModeMsg = new CacheWriteSynchronizationModeMessage(syncMode);
Review Comment:
i have seen this approach in different PRs. My guess is that readability was
the reason to preserve all the unnecessary `this`. As for me, it seems that
everything unnecessary should be removed, so i can completely agree with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
