chesnokoff commented on code in PR #12301:
URL: https://github.com/apache/ignite/pull/12301#discussion_r2469539462


##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -2997,6 +2998,12 @@ private RingMessageWorker(IgniteLogger log) {
 
                 runTasks();
             });
+
+            if (spi.ignite() instanceof IgniteEx) {
+                RollingUpgradeProcessor rollingUpgradeProcessor = 
((IgniteEx)spi.ignite()).context().rollingUpgrade();
+                if (rollingUpgradeProcessor != null)

Review Comment:
   If we remove this null check, 
TcpDiscoverySpiFailureTimeoutSelfTest#testConnectionCheckMessage will fail
   
   Looks like in some cases RingMessageWorker can be initialized before 
IgniteKernal
   
   Because of that I've added null check for `ring` in `enable` method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to