xtern commented on code in PR #6830:
URL: https://github.com/apache/ignite-3/pull/6830#discussion_r2476907799
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogHashIndexDescriptor.java:
##########
@@ -52,7 +70,7 @@ public CatalogHashIndexDescriptor(int id, String name, int
tableId, boolean uniq
* @param tableId Id of the table index belongs to.
* @param unique Unique flag.
* @param status Index status.
- * @param columns A list of indexed columns. Must not contains duplicates.
+ * @param columnIds A list of indexed columns. Must not contains
duplicates.
Review Comment:
```suggestion
* @param columnIds A list of indexed columns. Must not contain
duplicates.
```
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogHashIndexDescriptor.java:
##########
@@ -18,30 +18,48 @@
package org.apache.ignite.internal.catalog.descriptors;
import static
org.apache.ignite.internal.catalog.CatalogManager.INITIAL_TIMESTAMP;
+import static org.apache.ignite.internal.util.CollectionUtils.copyOrNull;
+import it.unimi.dsi.fastutil.ints.IntList;
import java.util.List;
import java.util.Objects;
import
org.apache.ignite.internal.catalog.storage.serialization.MarshallableEntryType;
import org.apache.ignite.internal.hlc.HybridTimestamp;
import org.apache.ignite.internal.tostring.S;
+import org.jetbrains.annotations.Nullable;
/** Hash index descriptor. */
public class CatalogHashIndexDescriptor extends CatalogIndexDescriptor {
- private final List<String> columns;
+ private final @Nullable IntList columnIds;
+ private final @Nullable List<String> columnNames;
/**
- * Constructs a hash index descriptor in status {@link
CatalogIndexStatus#REGISTERED}.
+ * Constructs a hash index descriptor.
*
* @param id Id of the index.
* @param name Name of the index.
* @param tableId Id of the table index belongs to.
* @param unique Unique flag.
- * @param columns A list of indexed columns. Must not contains duplicates.
+ * @param status Index status.
+ * @param columnNames A list of indexed columns. Must not contains
duplicates.
Review Comment:
```suggestion
* @param columnNames A list of indexed columns. Must not contain
duplicates.
```
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogHashIndexDescriptor.java:
##########
@@ -77,10 +95,9 @@ public CatalogHashIndexDescriptor(
* @param tableId Id of the table index belongs to.
* @param unique Unique flag.
* @param status Index status.
- * @param columns A list of indexed columns. Must not contains duplicates.
+ * @param columnNames A list of indexed columns. Must not contains
duplicates.
Review Comment:
```suggestion
* @param columnNames A list of indexed columns. Must not contain
duplicates.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
