NSAmelchev commented on code in PR #12473:
URL: https://github.com/apache/ignite/pull/12473#discussion_r2477919448
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java:
##########
@@ -486,12 +484,6 @@ private void updateClientNodes(UUID leftNodeId) {
ctx.addNodeAttribute(ATTR_OFFHEAP_SIZE, requiredOffheap());
ctx.addNodeAttribute(ATTR_DATA_REGIONS_OFFHEAP_SIZE,
configuredOffheap());
- // TODO When exposing to public interface, replace the retrieval in
IgniteClusterNode implementations.
- String dcId = IgniteSystemProperties.getString(IGNITE_DATA_CENTER_ID);
Review Comment:
I suggest leaving it as it was:
1. The datacenter ID is planned to be obtained not only from a system
property - the attributes still have to be explicitly set.
2. This seems like an implicit exception from the user configuration -
IgniteConfiguration#setIncludeProperties.
3. "IgniteNodeAttributes" class and corresponding naming of internal
attributes are more familiar in the code (i.e. "consistentId").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
