sanpwc commented on code in PR #6850:
URL: https://github.com/apache/ignite-3/pull/6850#discussion_r2514509765


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -3635,6 +3673,16 @@ public void changePeersAndLearners(final Configuration 
newPeersAndLearners, long
                     return;
             }
 
+            if (this.conf.getConf().getSequenceToken() > 
newPeersAndLearners.getSequenceToken()) {
+                 LOG.info("Node {} received stale configuration for conf {}, 
existing is {}, new {}.",
+                        getNodeId(), newPeersAndLearners, 
this.conf.getConf().getSequenceToken(),  
newPeersAndLearners.getSequenceToken());
+                Status status = 
staleConfiguration(newPeersAndLearners.getSequenceToken());

Review Comment:
   Please add comment explaining that ESTALE means stale proposed data and not 
stale server data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to