NSAmelchev commented on code in PR #12504:
URL: https://github.com/apache/ignite/pull/12504#discussion_r2518969091
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java:
##########
@@ -69,6 +72,16 @@ public void changeTopology(UUID prevNodeId) {
this.prevNodeId = prevNodeId;
}
+ /** @return DataCenter id.*/
+ public String dcId() {
+ return dcId;
+ }
+
+ /** @param dcId DataCenter id.*/
Review Comment:
```suggestion
/** @param dcId DataCenter id. */
```
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java:
##########
@@ -69,6 +72,16 @@ public void changeTopology(UUID prevNodeId) {
this.prevNodeId = prevNodeId;
}
+ /** @return DataCenter id.*/
Review Comment:
```suggestion
/** @return DataCenter id. */
```
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java:
##########
@@ -94,6 +99,16 @@ public void clientAck(boolean clientAck) {
setFlag(CLIENT_ACK_FLAG_POS, clientAck);
}
+ /** @return Socket addresses list for redirect.*/
Review Comment:
```suggestion
/** @return Socket addresses list for redirect. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
