Phillippko commented on code in PR #6948: URL: https://github.com/apache/ignite-3/pull/6948#discussion_r2526186430
########## modules/compatibility-tests/src/integrationTest/java/org/apache/ignite/internal/ItCmgRaftLogCompatibilityTest.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import static org.apache.ignite.internal.TestWrappers.unwrapIgniteImpl; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully; +import static org.apache.ignite.internal.util.IgniteUtils.deleteIfExists; +import static org.hamcrest.MatcherAssert.assertThat; + +import java.nio.file.Path; +import org.apache.ignite.Ignite; +import org.apache.ignite.internal.Cluster.ServerRegistration; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedClass; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * CMG Raft log compatibility tests. + */ +@ParameterizedClass +@MethodSource("baseVersions") +public class ItCmgRaftLogCompatibilityTest extends CompatibilityTestBase { + @Override + protected boolean restartWithCurrentEmbeddedVersion() { + return false; + } + + @Override + protected int nodesCount() { + return 1; + } + + @Override + protected void setupBaseVersion(Ignite baseIgnite) { + } + + @Test + void testCmgRaftLogReapplication() { + cluster.stop(); + + String nodeName = cluster.nodeName(0); + Path node0CmgDbPath = Path.of("cluster", nodeName, "cmg", "db"); Review Comment: Please reuse cluster.runnerNodeWorkDir method ########## modules/compatibility-tests/src/integrationTest/java/org/apache/ignite/internal/ItCmgRaftLogCompatibilityTest.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import static org.apache.ignite.internal.TestWrappers.unwrapIgniteImpl; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully; +import static org.apache.ignite.internal.util.IgniteUtils.deleteIfExists; +import static org.hamcrest.MatcherAssert.assertThat; + +import java.nio.file.Path; +import org.apache.ignite.Ignite; +import org.apache.ignite.internal.Cluster.ServerRegistration; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedClass; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * CMG Raft log compatibility tests. + */ +@ParameterizedClass +@MethodSource("baseVersions") +public class ItCmgRaftLogCompatibilityTest extends CompatibilityTestBase { + @Override + protected boolean restartWithCurrentEmbeddedVersion() { + return false; + } + + @Override + protected int nodesCount() { + return 1; + } + + @Override + protected void setupBaseVersion(Ignite baseIgnite) { + } + + @Test + void testCmgRaftLogReapplication() { + cluster.stop(); + + String nodeName = cluster.nodeName(0); + Path node0CmgDbPath = Path.of("cluster", nodeName, "cmg", "db"); + deleteIfExists(workDir.resolve(node0CmgDbPath)); + + cluster.startEmbedded(nodesCount()); + + verifyClusterState(0); + } + + @Test + void testCmgRaftLogReplication() { + final int initialNodeCount = nodesCount(); + final int finalNodeCount = nodesCount() + 1; + final int lastNodeIndex = finalNodeCount - 1; + + cluster.stop(); + cluster.startEmbedded(initialNodeCount); Review Comment: you can just start 2 cluster node now, no need to start them one by one (see MetastorageRaftCompatibilityTest.testStreamToFollower) ########## modules/compatibility-tests/src/integrationTest/java/org/apache/ignite/internal/ItCmgRaftLogCompatibilityTest.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import static org.apache.ignite.internal.TestWrappers.unwrapIgniteImpl; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully; +import static org.apache.ignite.internal.util.IgniteUtils.deleteIfExists; +import static org.hamcrest.MatcherAssert.assertThat; + +import java.nio.file.Path; +import org.apache.ignite.Ignite; +import org.apache.ignite.internal.Cluster.ServerRegistration; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedClass; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * CMG Raft log compatibility tests. + */ +@ParameterizedClass +@MethodSource("baseVersions") +public class ItCmgRaftLogCompatibilityTest extends CompatibilityTestBase { + @Override + protected boolean restartWithCurrentEmbeddedVersion() { + return false; + } + + @Override + protected int nodesCount() { + return 1; + } + + @Override + protected void setupBaseVersion(Ignite baseIgnite) { + } + + @Test + void testCmgRaftLogReapplication() { + cluster.stop(); + + String nodeName = cluster.nodeName(0); + Path node0CmgDbPath = Path.of("cluster", nodeName, "cmg", "db"); + deleteIfExists(workDir.resolve(node0CmgDbPath)); Review Comment: Let's delete workdir for both tests - it still uses raft log now, but what if we'll use different mechanism in the future. And to unify cmg and metastorage tests behaviour (imho they should look almost the same) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
