valepakh commented on code in PR #6974:
URL: https://github.com/apache/ignite-3/pull/6974#discussion_r2527979483
##########
buildscripts/generate-version-file.gradle:
##########
@@ -16,9 +16,20 @@
*/
def createVersionFile = tasks.register('createVersionFile') {
- onlyIf {
- project.hasProperty("lastCommitHash")
- }
+ def commitHash = project.hasProperty("lastCommitHash")
+ ? project.property("lastCommitHash")
+ : {
+ try {
Review Comment:
Could you please extract this to a function?
I'd probably move the whole this logic to a function instead of a variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
