wernerdv commented on code in PR #12508:
URL: https://github.com/apache/ignite/pull/12508#discussion_r2532168442
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionFullMap.java:
##########
@@ -25,27 +25,43 @@
import java.util.Iterator;
import java.util.Map;
import java.util.UUID;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.plugin.extensions.communication.Message;
import org.jetbrains.annotations.NotNull;
/**
* Full partition map from all nodes.
*/
public class GridDhtPartitionFullMap
- extends HashMap<UUID, GridDhtPartitionMap> implements
Comparable<GridDhtPartitionFullMap>, Externalizable {
+ extends HashMap<UUID, GridDhtPartitionMap> implements
Comparable<GridDhtPartitionFullMap>, Externalizable, Message {
Review Comment:
I propose extending AbstractMap instead of HashMap, which will allow us to
use utility methods for maps (such as `F.isEmpty` and
`GridCacheProcessor#filteredMap`).
All calls will be delegated to the internal map `fullMap`.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
