ibessonov commented on code in PR #6973:
URL: https://github.com/apache/ignite-3/pull/6973#discussion_r2533051803
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/LocalLocker.java:
##########
@@ -60,6 +80,11 @@ public boolean tryLock(RowId rowId) {
return false;
}
+ @Override
+ public boolean shouldRelease() {
+ return shouldReleaseSupplier != null &&
shouldReleaseSupplier.getAsBoolean();
+ }
Review Comment:
Can we make this method return `false` by default and override it when we
need? The "supplier" approach looks clumsy, honestly. Its absence would also
alleviate the need for some of the tests that check this particular line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
