ascherbakoff commented on code in PR #6779:
URL: https://github.com/apache/ignite-3/pull/6779#discussion_r2533459729
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTupleRequestBase.java:
##########
@@ -74,53 +77,42 @@ public Tuple tuple2() {
return tuple2;
}
- public static CompletableFuture<ClientTupleRequestBase> readAsync(
- ClientMessageUnpacker in,
- IgniteTables tables,
- ClientResourceRegistry resources,
- @Nullable TxManager txManager,
- boolean txReadOnly,
- @Nullable NotificationSender notificationSender,
- @Nullable HybridTimestampTracker tsTracker,
- boolean keyOnly
- ) {
- return readAsync(in, tables, resources, txManager, txReadOnly,
notificationSender, tsTracker, keyOnly, false);
+ public enum RequestOptions {
+ READ_ONLY,
+ KEY_ONLY,
+ READ_SECOND_TUPLE,
+ HAS_PRIORITY
}
public static CompletableFuture<ClientTupleRequestBase> readAsync(
ClientMessageUnpacker in,
IgniteTables tables,
ClientResourceRegistry resources,
- @Nullable TxManager txManager,
- boolean txReadOnly,
+ TxManager txManager,
@Nullable NotificationSender notificationSender,
@Nullable HybridTimestampTracker tsTracker,
- boolean keyOnly,
- boolean readSecondTuple
+ EnumSet<RequestOptions> options
) {
- assert (txManager != null) == (tsTracker != null) : "txManager and
tsTracker must be both null or not null";
Review Comment:
🆗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
