sk0x50 commented on code in PR #6977:
URL: https://github.com/apache/ignite-3/pull/6977#discussion_r2538230300
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogManagerCompactionFacade.java:
##########
@@ -38,39 +37,6 @@ class CatalogManagerCompactionFacade {
this.catalogManager = catalogManager;
}
- // TODO https://issues.apache.org/jira/browse/IGNITE-22522 Remove this
method.
- /**
- * Scans catalog versions in a given time interval (including interval
boundaries).
- * Extracts all tables contained in these catalog versions and creates a
mapping
- * tableId -> number of partitions in this table.
Review Comment:
Nice catch! Thanks. Fixed.
##########
modules/catalog-compaction/src/test/java/org/apache/ignite/internal/catalog/compaction/CatalogManagerCompactionFacadeTest.java:
##########
@@ -53,65 +46,6 @@ void setupHelper() {
catalogManagerFacade = new
CatalogManagerCompactionFacade(catalogManager);
}
- // TODO https://issues.apache.org/jira/browse/IGNITE-22522 Remove this
test.
- @Test
- void testCollectTablesWithPartitionsBetween() {
- CreateTableCommandBuilder tableCmdBuilder =
CreateTableCommand.builder()
- .schemaName("PUBLIC")
- .columns(List.of(columnParams("key1", INT32),
columnParams("key2", INT32), columnParams("val", INT32, true)))
-
.primaryKey(TableHashPrimaryKey.builder().columns(List.of("key1",
"key2")).build())
- .colocationColumns(List.of("key2"));
-
- DropTableCommandBuilder dropTableCommandBuilder =
DropTableCommand.builder()
- .schemaName("PUBLIC");
-
- long from1 = clockService.nowLong();
-
-
assertThat(catalogManager.execute(tableCmdBuilder.tableName("test1").build()),
willCompleteSuccessfully());
-
assertThat(catalogManager.execute(dropTableCommandBuilder.tableName("test1").build()),
willCompleteSuccessfully());
-
- long from2 = clockService.nowLong();
-
-
assertThat(catalogManager.execute(tableCmdBuilder.tableName("test2").build()),
willCompleteSuccessfully());
-
assertThat(catalogManager.execute(dropTableCommandBuilder.tableName("test2").build()),
willCompleteSuccessfully());
-
- long from3 = clockService.nowLong();
-
assertThat(catalogManager.execute(tableCmdBuilder.tableName("test3").build()),
willCompleteSuccessfully());
-
assertThat(catalogManager.execute(dropTableCommandBuilder.tableName("test3").build()),
willCompleteSuccessfully());
-
- {
- Int2IntMap tablesWithParts =
catalogManagerFacade.collectTablesWithPartitionsBetween(
- from1,
- clockService.nowLong());
-
- assertThat(tablesWithParts.keySet(), hasSize(3));
- }
-
- {
- Int2IntMap tablesWithParts =
catalogManagerFacade.collectTablesWithPartitionsBetween(
- from2,
- clockService.nowLong());
-
- assertThat(tablesWithParts.keySet(), hasSize(2));
- }
-
- {
- Int2IntMap tablesWithParts =
catalogManagerFacade.collectTablesWithPartitionsBetween(
- from3,
- clockService.nowLong());
-
- assertThat(tablesWithParts.keySet(), hasSize(1));
- }
-
- {
- Int2IntMap tablesWithParts =
catalogManagerFacade.collectTablesWithPartitionsBetween(
- clockService.nowLong(),
- clockService.nowLong());
-
- assertThat(tablesWithParts.keySet(), hasSize(0));
- }
- }
-
@Test
void testCollectZonesWithPartitionsBetween() {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
