AMashenkov commented on code in PR #6958:
URL: https://github.com/apache/ignite-3/pull/6958#discussion_r2538495584
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Inbox.java:
##########
@@ -392,7 +392,12 @@ private void requestBatches(String nodeName, int cnt,
@Nullable SharedState stat
}
/** Notifies the inbox that provided node has left the cluster. */
- public void onNodeLeft(InternalClusterNode node) {
+ public void onNodeLeft(InternalClusterNode node, long version) {
+ Long topologyVersion = context().topologyVersion();
+ if (topologyVersion != null && topologyVersion > version) {
+ return;
Review Comment:
```suggestion
return; // Ignore outdated event.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingService.java:
##########
@@ -33,4 +33,8 @@ public interface MappingService {
* @return A list of fragments with metadata related to a fragment
topology.
*/
CompletableFuture<List<MappedFragment>> map(MultiStepPlan multiStepPlan,
MappingParameters parameters);
+
+ default CompletableFuture<MappedFragments> map2(MultiStepPlan
multiStepPlan, MappingParameters parameters) {
Review Comment:
Do we need old method? Can it be removed or marked as Deprecated?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Outbox.java:
##########
@@ -356,7 +356,12 @@ private void flush() throws Exception {
}
/** Notifies the outbox that provided node has left the cluster. */
- public void onNodeLeft(InternalClusterNode node) {
+ public void onNodeLeft(InternalClusterNode node, long version) {
+ Long topologyVersion = context().topologyVersion();
+ if (topologyVersion != null && topologyVersion > version) {
+ return;
Review Comment:
```suggestion
return; // Ignore outdated event.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
