arcolight commented on code in PR #7001:
URL: https://github.com/apache/ignite-3/pull/7001#discussion_r2538575159
##########
modules/platforms/cpp/ignite/odbc/sql_connection.cpp:
##########
@@ -70,6 +70,10 @@ std::vector<ignite::end_point> collect_addresses(const
ignite::configuration &cf
namespace ignite {
+sql_connection::~sql_connection() {
Review Comment:
Environment holds only raw pointer to the `shared_pointer`, so
deregistration does not mean we delete connection, it will be done by separate
call and we use `weak_ptr` inside the closure in the `plan_heartbeat()`, so
`lock()` will fail and nothing will be called in case connection is already
destroyed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
