alex-plekhanov commented on code in PR #12518:
URL: https://github.com/apache/ignite/pull/12518#discussion_r2544556755
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/QueryHistory.java:
##########
@@ -47,13 +47,15 @@ public class QueryHistory {
* @param startTime Start time of query execution.
* @param duration Duration of query execution.
* @param failed {@code True} query executed unsuccessfully {@code false}
otherwise.
+ * @param initId Initiator ID.
*/
- public QueryHistory(String qry, String schema, boolean loc, long
startTime, long duration, boolean failed) {
+ public QueryHistory(String qry, String schema, boolean loc, long
startTime, long duration, boolean failed,
Review Comment:
Please fix codestyle (in case of multi-line declaration, each parameter
should be on it's own line)
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/QueryHistoryMetricsValue.java:
##########
@@ -37,19 +39,25 @@ class QueryHistoryMetricsValue {
/** Last start time of execution. */
private final long lastStartTime;
+ /** Latest user-defined initiator ID. */
+ private final String initId;
+
/**
* @param execs Number of executions.
* @param failures Number of failure.
* @param minTime Min time of execution.
* @param maxTime Max time of execution.
* @param lastStartTime Last start time of execution.
+ * @param initId Latest initiator ID.
*/
- public QueryHistoryMetricsValue(long execs, long failures, long minTime,
long maxTime, long lastStartTime) {
+ public QueryHistoryMetricsValue(long execs, long failures, long minTime,
long maxTime, long lastStartTime,
+ @Nullable String initId) {
Review Comment:
Please fix codestyle
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlQueryHistorySelfTest.java:
##########
@@ -423,6 +435,22 @@ public void
testSqlFieldsQueryHistoryCrossCacheQueryNotFullyFetched() throws Exc
private void checkMetrics(int sz, int idx, int execs, int failures,
boolean first) {
+ checkMetrics(sz, idx, execs, failures, first, null);
+ }
+
+ /**
+ * Check metrics.
+ *
+ * @param sz Expected size of metrics.
+ * @param idx Index of metrics to check.
+ * @param execs Expected number of executions.
+ * @param failures Expected number of failures.
+ * @param first {@code true} if metrics checked for first query only.
+ * @param initId Initiator ID.
+ */
+ private void checkMetrics(int sz, int idx, int execs, int failures,
+ boolean first, String initId) {
Review Comment:
Please fix codestyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
