timoninmaxim commented on code in PR #12521: URL: https://github.com/apache/ignite/pull/12521#discussion_r2545191167
########## modules/core/src/main/java/org/apache/ignite/internal/management/rollingupgrade/RollingUpgradeStatusCommand.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.management.rollingupgrade; + +import java.util.Collection; +import java.util.function.Consumer; +import org.apache.ignite.IgniteException; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.internal.management.api.ComputeCommand; +import org.apache.ignite.internal.management.api.NoArg; +import org.apache.ignite.lang.IgniteExperimental; + +import static org.apache.ignite.internal.management.api.CommandUtils.coordinatorOrNull; + +/** Command to get status of rolling upgrade mode. */ +@IgniteExperimental +public class RollingUpgradeStatusCommand implements ComputeCommand<NoArg, RollingUpgradeTaskResult> { + /** {@inheritDoc} */ + @Override public String description() { + return "Get status of rolling upgrade mode"; + } + + /** {@inheritDoc} */ + @Override public Class<NoArg> argClass() { + return NoArg.class; + } + + /** {@inheritDoc} */ + @Override public Class<RollingUpgradeStatusTask> taskClass() { + return RollingUpgradeStatusTask.class; + } + + /** {@inheritDoc} */ + @Override public void printResult(NoArg arg, RollingUpgradeTaskResult res, Consumer<String> printer) { + printer.accept("Rolling upgrade status: " + (res.targetVersion() != null ? "enabled" : "disabled")); + + if (res.targetVersion() != null) { + printer.accept("Current version: " + res.currentVersion()); + printer.accept("Target version: " + res.targetVersion()); + } + + printer.accept("Cluster nodes and their versions:"); + + if (res.nodes() == null || res.nodes().isEmpty()) { + printer.accept(" No nodes information available"); + return; + } + + res.nodes().stream() + .map(node -> " NodeId=" + node.nodeId() + ", Version=" + node.version()) Review Comment: I suppose we should have 2 lists, each (version + nodes). Version1: node1 node2 Version2: node3 node4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
