petrov-mg commented on code in PR #12429: URL: https://github.com/apache/ignite/pull/12429#discussion_r2546237227
########## modules/commons/src/main/java/org/apache/ignite/internal/thread/context/ScopedContext.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.thread.context; + +/** */ +public final class ScopedContext extends ContextDataChain<ScopedContext> { + /** */ + private static final ScopedContext ROOT = new ScopedContext(); + + /** */ + private final ContextAttribute<?> attr; + + /** */ + private final Object val; + + /** */ + private ScopedContext() { + attr = null; + val = null; + } + + /** */ + private <T> ScopedContext(ContextAttribute<T> attr, T val, ScopedContext prev) { + super(prev.storedAttributeBits() | attr.bitmask(), prev); + + this.attr = attr; + this.val = val; + } + + /** */ + public <T> ScopedContext with(ContextAttribute<T> attr, T val) { Review Comment: `it's a responsibility of Scope to store all attributes within single scope` Nope. See comments above. I changed class naming a bit so it may be less confusing now. `Looks weird, an object that stores an attribute value accepts another attribute (name + value)` Also keep in mind that the current patch is based on intrusive lists and it is unlikely to be possible to avoid the "weirdness" you mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
