Copilot commented on code in PR #7034:
URL: https://github.com/apache/ignite-3/pull/7034#discussion_r2549569880
##########
modules/platforms/dotnet/Apache.Ignite/Internal/ClientSocket.cs:
##########
@@ -934,19 +941,22 @@ private bool HandleResponseInner(PooledBuffer response)
throw new
IgniteClientConnectionException(ErrorGroups.Client.Protocol, message);
}
+ _logger.LogReceivedResponseTrace(
+ requestId, pendingReq.Op, flags,
ConnectionContext.ClusterNode.Address,
Stopwatch.GetElapsedTime(pendingReq.StartTs));
Review Comment:
Extra space after `flags,` - should be single space between arguments.
```suggestion
requestId, pendingReq.Op, flags,
ConnectionContext.ClusterNode.Address,
Stopwatch.GetElapsedTime(pendingReq.StartTs));
```
##########
modules/platforms/dotnet/Apache.Ignite/Internal/ClientSocket.cs:
##########
@@ -903,12 +903,19 @@ private bool HandleResponseInner(PooledBuffer response)
var requestId = reader.ReadInt64();
var flags = (ResponseFlags)reader.ReadInt32();
- _logger.LogReceivedResponseTrace(requestId, flags,
ConnectionContext.ClusterNode.Address);
+ var isServerOp = (flags & ResponseFlags.ServerOp) != 0;
+ var isError = (flags & ResponseFlags.Error) != 0;
+ var isNotification = (flags & ResponseFlags.Notification) != 0;
+
+ if (isServerOp || isNotification)
+ {
+ _logger.LogReceivedResponseTrace(requestId, ClientOp.None,
flags, ConnectionContext.ClusterNode.Address, null);
Review Comment:
Extra space after `flags,` - should be single space between arguments.
```suggestion
_logger.LogReceivedResponseTrace(requestId, ClientOp.None,
flags, ConnectionContext.ClusterNode.Address, null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
