korlov42 opened a new pull request, #7038:
URL: https://github.com/apache/ignite-3/pull/7038

   https://issues.apache.org/jira/browse/IGNITE-27120
   
   To reproduce the issue, add artificial delay like this:
   ```
   org.apache.ignite.internal.sql.engine.exec.fsm.QueryExecutor#trackQuery:
   
       private void trackQuery(Query query, @Nullable CancellationToken 
cancellationToken) {
           Query old = runningQueries.put(query.id, query);
   
           try {
               Thread.sleep(1_000);
           } catch (InterruptedException e) {
               throw new RuntimeException(e);
           }
   ```
   
   If query doesn't moved to the certain execution phase, transaction in fact 
is not used, thus cancellation won't affect it.
   
   Proposed solution is to derive cursor publication part to a distinct phase 
called `CURSOR_PUBLICATION`, and wait in test until query transitioned to this 
to make sure cursor is created and transaction indeed linked to this query.
   
   ----
   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE-XXXX Change summary where XXXX - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to