Copilot commented on code in PR #7037:
URL: https://github.com/apache/ignite-3/pull/7037#discussion_r2550241377
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -78,6 +78,7 @@
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][;param
*** `keyStorePassword` - Key store password.
*** `clientAuth` - SSL client authentication. Possible values: `NONE`,
`OPTIONAL`, `REQUIRE`.
*** `ciphers` - comma-separated SSL ciphers list.
+** `partitionAwarenessMetadataCacheSize` - Size of cache to store partition
awareness metadata of queries, in number of entries. Default value: `1024`.
Review Comment:
Grammar issue: "Size of cache to store" should be "Size of the cache to
store" or more concisely "Cache size for storing" for better grammatical
correctness.
```suggestion
** `partitionAwarenessMetadataCacheSize` - Cache size for storing partition
awareness metadata of queries, in number of entries. Default value: `1024`.
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -98,19 +101,26 @@ Here is how you can commit a transaction:
// Open the JDBC connection.
Connection conn =
DriverManager.getConnection("jdbc:ignite:thin://127.0.0.1:10800");
+// Disable auto-commit mode.
+conn.setAutoCommit(false);
+
// Commit a transaction
conn.commit();
----
-You can also configure Apache Ignite to automatically commit transactions by
using the `setAutoCommit()` method.
-
Here is how you can rollback a transaction:
[source, java]
----
conn.rollback();
----
+== Partition Awareness
+
+Partition awareness is supported by the JDBC driver.
+
+See link:developers-guide/clients/overview#partition-awareness[Partition
Awareness Overview] for more details.
Review Comment:
The link text "Partition Awareness Overview" doesn't match the actual
section title in the overview.adoc file, which is simply "Partition Awareness".
The link text should be updated to match the section title for consistency.
```suggestion
See link:developers-guide/clients/overview#partition-awareness[Partition
Awareness] for more details.
```
##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -89,7 +90,9 @@ If the same parameters are passed by using different means,
the JDBC driver prio
== Performing Transactions
-With the JDBC driver, you can perform `commit` and `rollback` transactions.
For more information about transactions, see
link:developers-guide/transactions[Performing Transactions].
+By default a JDBC connection is in auto-commit mode, and in this mode all its
SQL statements will be executed and committed as individual transactions.
+To be able to manage the transaction, you must switch connection to
non-autocommit mode (see
link:https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/Connection.html#setAutoCommit(boolean)[java
documentation]).
Review Comment:
Grammar issues: "To be able to manage the transaction, you must switch
connection" should be "To be able to manage transactions, you must switch the
connection" for grammatical correctness. Using the plural "transactions" is
more appropriate since this refers to transaction management in general, and
"the connection" is needed as the article is missing.
```suggestion
To be able to manage transactions, you must switch the connection to
non-autocommit mode (see
link:https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/Connection.html#setAutoCommit(boolean)[java
documentation]).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
