sk0x50 commented on code in PR #7053:
URL: https://github.com/apache/ignite-3/pull/7053#discussion_r2556643871
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/ReadResult.java:
##########
@@ -62,22 +61,22 @@ private ReadResult(
RowId rowId,
@Nullable BinaryRow binaryRow,
@Nullable UUID transactionId,
- @Nullable Integer commitTableOrZoneId,
+ @Nullable Integer commitZoneId,
@Nullable HybridTimestamp commitTs,
@Nullable HybridTimestamp newestCommitTs,
int commitPartitionId
) {
this.rowId = rowId;
this.binaryRow = binaryRow;
- // If transaction is not null, then commitTableId and
commitPartitionId should be defined.
- assert (transactionId == null) || (commitTableOrZoneId != null &&
commitPartitionId != -1);
+ // If transaction id is not null, then commitZoneId and
commitPartitionId should be defined.
+ assert (transactionId == null) || (commitZoneId != null &&
commitPartitionId != -1);
- // If transaction id is null, then commitTableId and commitPartitionId
should not be defined.
- assert (transactionId != null) || (commitTableOrZoneId == null &&
commitPartitionId == -1);
+ // If transaction id is null, then commitZoneId and commitPartitionId
should not be defined.
+ assert (transactionId != null) || (commitZoneId == null &&
commitPartitionId == -1);
this.transactionId = transactionId;
- this.commitTableOrZoneId = commitTableOrZoneId;
+ this.commitZoneId = commitZoneId;
this.commitTs = commitTs;
this.newestCommitTs = newestCommitTs;
this.commitPartitionId = commitPartitionId;
Review Comment:
nice catch! fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
