vadimkolodingg commented on code in PR #6931:
URL: https://github.com/apache/ignite-3/pull/6931#discussion_r2559787365
##########
modules/api/src/main/java/org/apache/ignite/table/mapper/MapperBuilder.java:
##########
@@ -114,13 +114,7 @@ private static <O> Class<O> ensureValidPojo(Class<O> type)
{
throw new IllegalArgumentException("Unsupported class. Interfaces
are not supported: " + type.getName());
}
- try {
- type.getDeclaredConstructor();
-
- return type;
- } catch (NoSuchMethodException e) {
- throw new IllegalArgumentException("Class must have default
constructor: " + type.getName());
- }
+ return type;
Review Comment:
There is still bunch of validations above that line. This is a private
method, I don't mind leaving its name as it is. Sophisticated validation
happens a bit deeper - on constructor introspection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
