arcolight commented on code in PR #7096:
URL: https://github.com/apache/ignite-3/pull/7096#discussion_r2568148333
##########
modules/platforms/cpp/ignite/network/ssl/secure_socket_client.cpp:
##########
@@ -39,6 +39,33 @@ void free_bio(BIO* bio)
gateway.BIO_free_all_(bio);
}
+SSL* ssl_from_bio_no_check(void* bio) {
+ ssl_gateway &gateway = ssl_gateway::get_instance();
+ SSL* ssl = nullptr;
+ gateway.BIO_get_ssl_(reinterpret_cast<BIO*>(bio), &ssl);
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, ignite::error::code on_fail_code, const
std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw ignite::ignite_error(on_fail_code, on_fail_msg);
+
+ assert(ssl != nullptr);
Review Comment:
Makes sense, removed
##########
modules/platforms/cpp/ignite/network/ssl/secure_socket_client.cpp:
##########
@@ -39,6 +39,33 @@ void free_bio(BIO* bio)
gateway.BIO_free_all_(bio);
}
+SSL* ssl_from_bio_no_check(void* bio) {
+ ssl_gateway &gateway = ssl_gateway::get_instance();
+ SSL* ssl = nullptr;
+ gateway.BIO_get_ssl_(reinterpret_cast<BIO*>(bio), &ssl);
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, ignite::error::code on_fail_code, const
std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw ignite::ignite_error(on_fail_code, on_fail_msg);
+
+ assert(ssl != nullptr);
+
+ return ssl;
+}
+
+SSL* ssl_from_bio(void* bio, const std::string& on_fail_msg) {
+ SSL* ssl = ssl_from_bio_no_check(bio);
+ if (!ssl)
+ throw_last_secure_error(on_fail_msg);
+
+ assert(ssl != nullptr);
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
