sashapolo commented on code in PR #7092:
URL: https://github.com/apache/ignite-3/pull/7092#discussion_r2569198558
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/io/HashIndexTreeIo.java:
##########
@@ -209,19 +205,25 @@ default int compare(DataPageReader dataPageReader, int
partitionId, long pageAdd
CompareIndexColumnsValue compareIndexColumnsValue = new
CompareIndexColumnsValue();
- dataPageReader.traverse(link, compareIndexColumnsValue,
row.indexColumns().valueBuffer().rewind().duplicate());
+ dataPageReader.traverse(link, compareIndexColumnsValue,
rowKey.indexColumns().valueBuffer().rewind().duplicate());
cmp = compareIndexColumnsValue.compareResult();
} else {
ByteBuffer indexColumnsBuffer = wrapPointer(pageAddr + off +
TUPLE_OFFSET, indexColumnsSize);
- cmp =
indexColumnsBuffer.compareTo(row.indexColumns().valueBuffer().rewind());
+ cmp =
indexColumnsBuffer.compareTo(rowKey.indexColumns().valueBuffer().rewind());
}
if (cmp != 0) {
return cmp;
}
+ if (!(rowKey instanceof HashIndexRow)) {
Review Comment:
What else can it be?
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/index/AbstractIndexStorageTest.java:
##########
@@ -244,57 +241,6 @@ public void testGet() {
assertThat(getAll(index, row4), is(empty()));
}
- @Test
- public void testGetConcurrentPut() {
Review Comment:
Why did you remove these tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
