zstan commented on code in PR #7093:
URL: https://github.com/apache/ignite-3/pull/7093#discussion_r2570589590


##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -72,6 +72,11 @@ 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][;param
 ** `partitionAwarenessMetadataCacheSize` - Size of cache to store partition 
awareness metadata of queries, in number of entries. Default value: `1024`.
 ** `queryTimeout` - Number of seconds the driver will wait for a `Statement` 
object to execute. 0 means there is no limit. Default value: `0`.
 ** `connectionTimeout` - Number of milliseconds JDBC client will wait for 
server to respond. 0 means there is no limit. Default value: `0`.
+** `backgroundReconnectInterval` - Background reconnect interval, in 
milliseconds. The value `0` can be used to disable background reconnection. 
Default value is `30000` (30 seconds).

Review Comment:
   I don\`t like word "background" here, it`s smth from implementation and not 
UI related, just confused as for me. I read this description and still have a 
questions - what exactly changes for me from user point of view if i set it for 
20 for example, or to smth huge ? Can you expand the description ?



##########
docs/_docs/developers-guide/clients/jdbc-driver.adoc:
##########
@@ -72,6 +72,11 @@ 
jdbc:ignite:thin://host[:port][,host[:port][/schema][[?parameter1=value1][;param
 ** `partitionAwarenessMetadataCacheSize` - Size of cache to store partition 
awareness metadata of queries, in number of entries. Default value: `1024`.
 ** `queryTimeout` - Number of seconds the driver will wait for a `Statement` 
object to execute. 0 means there is no limit. Default value: `0`.
 ** `connectionTimeout` - Number of milliseconds JDBC client will wait for 
server to respond. 0 means there is no limit. Default value: `0`.
+** `backgroundReconnectInterval` - Background reconnect interval, in 
milliseconds. The value `0` can be used to disable background reconnection. 
Default value is `30000` (30 seconds).
+Background reconnection is used to restore old and establish new connections 
to cluster nodes in the background.
+For example, if you disable it, the client will not try to restore connections 
to temporarily unavailable cluster nodes.
+** `reconnectRetriesLimit` - Maximum number of *retry* attempts to establish 
connection. The value `0` means that no retries will be made. The value `-1` 
means that the number of retries is not limited. Default value is `16`.

Review Comment:
   Let`s suppose we have long living (as in practice))) ) cluster with 
temporary connection failures, as i can see now it counts for 16 and will stop 
to reconnect ? As for me it looks like very strange - client need to try to 
connect until success. Probably there is some logic in such a design but 
currently it look like strange for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to