ibessonov commented on code in PR #7109:
URL: https://github.com/apache/ignite-3/pull/7109#discussion_r2571406635
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -1068,4 +1059,48 @@ public CompletableFuture<Void> destroyIndex(int indexId)
{
* @see MvPartitionStorage#estimatedSize
*/
public abstract void decrementEstimatedSize();
+
+ private List<GcEntry> peekSingleGcEntryBusy(HybridTimestamp lowWatermark) {
+ GcRowVersion head = renewableState.gcQueue().getFirst();
+
+ // Garbage collection queue is empty.
+ if (head == null) {
+ return List.of();
+ }
+
+ HybridTimestamp rowTimestamp = head.getTimestamp();
+
+ // There are no versions in the garbage collection queue before
watermark.
+ if (rowTimestamp.compareTo(lowWatermark) > 0) {
+ return List.of();
+ }
+
+ return List.of(head);
+ }
+
+ private List<GcEntry> peekGcEntriesBusy(HybridTimestamp lowWatermark, int
count) {
+ var res = new ArrayList<GcEntry>(count);
+
+ try (Cursor<GcRowVersion> cursor = renewableState.gcQueue().find(null,
null)) {
+ while (res.size() < count && cursor.hasNext()) {
+ GcRowVersion next = cursor.next();
+
+ if (next.getTimestamp().compareTo(lowWatermark) > 0) {
+ break;
+ }
+
+ res.add(next);
Review Comment:
Please elaborate. I don't think that we need a separate method that will be
called "from the outside", hiding this in the implementation makes more sense
to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
