Copilot commented on code in PR #7111:
URL: https://github.com/apache/ignite-3/pull/7111#discussion_r2575737664
##########
modules/sql-engine/src/integrationTest/sql/group1/syscolumns/system_columns.test:
##########
@@ -15,12 +15,12 @@ insert into t0 values (103, 'val3');
# statement error: Failed to validate query:
statement error
----
-insert into t0 (id, val, __part) values (104, 'val4', 1)
+insert into t0 (id, val, __partition_id) values (104, 'val4', 1)
# statement error: Failed to validate query:
statement error
----
-insert into t0 (id, val, "__part") values (104, 'val4', 1)
+insert into t0 (id, val, __partition_id) values (104, 'val4', 1)
Review Comment:
The test cases on lines 18 and 23 are now identical. Previously, line 18
tested the unquoted `__part` identifier and line 23 tested the quoted
`"__part"` identifier. Both should be updated to test the new `__partition_id`
column, but the second one should test the quoted form to maintain the test's
original purpose of verifying both quoted and unquoted identifiers are rejected.
Line 23 should be:
```
insert into t0 (id, val, "__partition_id") values (104, 'val4', 1)
```
##########
docs/_docs/developers-guide/sql/sql-api.adoc:
##########
@@ -76,18 +76,18 @@ System.out.println("\nAdded accounts: " + rowsAdded);
== Partition-Specific SELECTs
-When executing a SELECT operation, you can use the system `\__part` column to
only `SELECT` data in a specific partition. To find out partition information,
use the SELECT request that explicitly includes the `__part` column as its part:
+When executing a SELECT operation, you can use the system `\__partition_id`
column to only `SELECT` data in a specific partition. To find out partition
information, use the SELECT request that explicitly includes the `__part`
column as its part:
Review Comment:
Inconsistency in documentation: Line 79 mentions using `__partition_id`
column, but then says "use the SELECT request that explicitly includes the
`__part` column as its part". This should consistently refer to
`__partition_id` as the primary column name, while mentioning that `__part` and
`"__part"` are legacy names kept for backward compatibility.
Suggested correction:
```
When executing a SELECT operation, you can use the system `\__partition_id`
column to only `SELECT` data in a specific partition. To find out partition
information, use the SELECT request that explicitly includes the
`__partition_id` column:
```
```suggestion
When executing a SELECT operation, you can use the system `__partition_id`
column to only `SELECT` data in a specific partition. To find out partition
information, use the SELECT request that explicitly includes the
`__partition_id` column. (Note: `__part` and `"__part"` are legacy names kept
for backward compatibility.)
```
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/sqllogic/ItSqlLogicTest.java:
##########
@@ -150,7 +150,7 @@
@WithSystemProperty(key = "IMPLICIT_PK_ENABLED", value = "true")
// The following is to make sure we unlock LWM on data nodes promptly so that
dropped tables are destroyed fast.
@WithSystemProperty(key =
ResourceVacuumManager.RESOURCE_VACUUM_INTERVAL_MILLISECONDS_PROPERTY, value =
"1000")
-@SqlLogicTestEnvironment(scriptsRoot = "src/integrationTest/sql/group1")
+@SqlLogicTestEnvironment(scriptsRoot = "src/integrationTest/sql/group1", regex
= "system_columns\\.test")
Review Comment:
The regex filter limits this test to only run `system_columns.test`, which
restricts all other tests in the `src/integrationTest/sql/group1` directory
from running. This appears to be a debug/development setting that should be
removed before merging.
Remove the `regex` parameter to run all tests in the directory:
```java
@SqlLogicTestEnvironment(scriptsRoot = "src/integrationTest/sql/group1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
