Copilot commented on code in PR #7004:
URL: https://github.com/apache/ignite-3/pull/7004#discussion_r2581989528
##########
.teamcity/build/distributions/OdbcZip.kt:
##########
@@ -33,34 +27,32 @@ object OdbcZip : BuildType({
odbcinst -j || exit 0
cat /etc/odbcinst.ini || exit 0
-
- conan --version
- conan profile list
- conan profile show default || exit 0
-
- conan info --path . || exit 0
""".trimIndent()
}
customGradle {
- name = "Build Zip"
- tasks = ":packaging-odbc:distZip -i -Pplatforms.enable"
- workingDir = "%VCSROOT__IGNITE3%"
+ name = "Build ODBC Zip (Under Rocky Linux 8 container)"
+ tasks = ":packaging-odbc:distZip"
+ workingDir = "%VCSROOT__GRIDGAIN9%"
Review Comment:
Inconsistent VCS root references: `workingDir` uses `%VCSROOT__GRIDGAIN9%`
while `artifactRules` still references `%VCSROOT__IGNITE3%`. This mismatch will
cause the build to generate artifacts in the IGNITE3 VCS root path but execute
Gradle tasks in the GRIDGAIN9 working directory, likely resulting in build
failures or missing artifacts.
Both should use the same VCS root reference. Based on the rest of the
codebase using `VCSROOT__IGNITE3`, consider changing line 36 to use
`%VCSROOT__IGNITE3%` instead of `%VCSROOT__GRIDGAIN9%`.
##########
.teamcity/build/distributions/OdbcRpm.kt:
##########
@@ -26,49 +27,22 @@ object OdbcRpm : BuildType({
odbcinst -j || exit 0
cat /etc/odbcinst.ini || exit 0
-
- conan --version
- conan profile list
- conan profile show default || exit 0
-
- conan info --path . || exit 0
""".trimIndent()
}
customGradle {
- tasks = ":packaging-odbc:buildRpm -i -Pplatforms.enable"
- workingDir = "%VCSROOT__IGNITE3%"
- }
-
- script {
- name = "[HACK] Set AGENT_NUMBER"
- id = "HACK_Set_AGENT_NUMBER"
- enabled = false
- scriptContent = """
- AGENT_NUMBER=${'$'}(echo %system.agent.name% | tail -c 3)
- echo "##teamcity[setParameter name='AGENT_NUMBER'
value='${'$'}{AGENT_NUMBER}']"
- """.trimIndent()
- }
-
- exec {
name = "Build ODBC RPM (Under Rocky Linux 8 container)"
- id = "Build_ODBC_RPM_Under_Rocky_Linux_8_container"
- enabled = false
- path = "./gradlew"
- arguments = ":packaging-odbc:buildRpm -i -Pplatforms.enable"
- dockerImage = "ggshared/tc-agent:rockylinux_latest"
- dockerImagePlatform = ExecBuildStep.ImagePlatform.Linux
+ tasks = ":packaging-odbc:buildRpm"
+ workingDir = "%VCSROOT__GRIDGAIN9%"
Review Comment:
Inconsistent VCS root references: `workingDir` uses `%VCSROOT__GRIDGAIN9%`
while `artifactRules` still references `%VCSROOT__IGNITE3%`. This mismatch will
cause the build to generate artifacts in the IGNITE3 VCS root path but execute
Gradle tasks in the GRIDGAIN9 working directory, likely resulting in build
failures or missing artifacts.
Both should use the same VCS root reference. Based on the rest of the
codebase using `VCSROOT__IGNITE3`, consider changing line 36 to use
`%VCSROOT__IGNITE3%` instead of `%VCSROOT__GRIDGAIN9%`.
```suggestion
workingDir = "%VCSROOT__IGNITE3%"
```
##########
.teamcity/build/distributions/OdbcZip.kt:
##########
@@ -33,34 +27,32 @@ object OdbcZip : BuildType({
odbcinst -j || exit 0
cat /etc/odbcinst.ini || exit 0
-
- conan --version
- conan profile list
- conan profile show default || exit 0
-
- conan info --path . || exit 0
""".trimIndent()
}
customGradle {
- name = "Build Zip"
- tasks = ":packaging-odbc:distZip -i -Pplatforms.enable"
- workingDir = "%VCSROOT__IGNITE3%"
+ name = "Build ODBC Zip (Under Rocky Linux 8 container)"
+ tasks = ":packaging-odbc:distZip"
+ workingDir = "%VCSROOT__GRIDGAIN9%"
+ gradleParams = "-i -Pplatforms.enable"
+ dockerImage = "docker.gridgain.com/ci/tc-rockylinux8-odbc:v1.0"
+ dockerPull = true
+ dockerImagePlatform = GradleBuildStep.ImagePlatform.Linux
+ dockerRunParameters = "-e JAVA_HOME=%CONTAINER_JAVA_HOME%"
}
-
customGradle {
- name = "Build Tar"
- id = "Build_Tar"
- tasks = ":packaging-odbc:distTar -i -Pplatforms.enable"
- workingDir = "%VCSROOT__IGNITE3%"
+ name = "Build ODBC Tar (Under Rocky Linux 8 container)"
+ tasks = ":packaging-odbc:distTar"
+ workingDir = "%VCSROOT__GRIDGAIN9%"
Review Comment:
Inconsistent VCS root references: `workingDir` uses `%VCSROOT__GRIDGAIN9%`
while `artifactRules` still references `%VCSROOT__IGNITE3%`. This mismatch will
cause the build to generate artifacts in the IGNITE3 VCS root path but execute
Gradle tasks in the GRIDGAIN9 working directory, likely resulting in build
failures or missing artifacts.
Both should use the same VCS root reference. Based on the rest of the
codebase using `VCSROOT__IGNITE3`, consider changing line 46 to use
`%VCSROOT__IGNITE3%` instead of `%VCSROOT__GRIDGAIN9%`.
```suggestion
workingDir = "%VCSROOT__IGNITE3%"
```
##########
.teamcity/build/distributions/OdbcDeb.kt:
##########
@@ -32,26 +27,21 @@ object OdbcDeb : BuildType({
odbcinst -j || exit 0
cat /etc/odbcinst.ini || exit 0
-
- conan --version
- conan profile list
- conan profile show default || exit 0
-
- conan info --path . || exit 0
""".trimIndent()
}
customGradle {
- name = "Build Deb"
- tasks = ":packaging-odbc:buildDeb -i -Pplatforms.enable"
- workingDir = "%VCSROOT__IGNITE3%"
+ name = "Build ODBC DEB (Under Rocky Linux 8 container)"
+ tasks = ":packaging-odbc:buildDeb"
+ workingDir = "%VCSROOT__GRIDGAIN9%"
Review Comment:
Inconsistent VCS root references: `workingDir` uses `%VCSROOT__GRIDGAIN9%`
while `artifactRules` still references `%VCSROOT__IGNITE3%`. This mismatch will
cause the build to generate artifacts in the IGNITE3 VCS root path but execute
Gradle tasks in the GRIDGAIN9 working directory, likely resulting in build
failures or missing artifacts.
Both should use the same VCS root reference. Based on the rest of the
codebase using `VCSROOT__IGNITE3`, consider changing line 35 to use
`%VCSROOT__IGNITE3%` instead of `%VCSROOT__GRIDGAIN9%`.
```suggestion
workingDir = "%VCSROOT__IGNITE3%"
```
##########
.teamcity/build/distributions/OdbcRpm.kt:
##########
@@ -3,6 +3,7 @@ package build.distributions
import jetbrains.buildServer.configs.kotlin.BuildType
import jetbrains.buildServer.configs.kotlin.buildSteps.ExecBuildStep
+import jetbrains.buildServer.configs.kotlin.buildSteps.GradleBuildStep
import jetbrains.buildServer.configs.kotlin.buildSteps.exec
Review Comment:
Unused imports: `ExecBuildStep` and `exec` are no longer used after the
removal of the disabled exec build step. These imports should be removed to
keep the code clean.
```suggestion
import jetbrains.buildServer.configs.kotlin.buildSteps.GradleBuildStep
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
