timoninmaxim commented on code in PR #12569:
URL: https://github.com/apache/ignite/pull/12569#discussion_r2606052948
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientChannelConfiguration.java:
##########
@@ -172,10 +176,26 @@ public boolean isTcpNoDelay() {
}
/**
+ * @deprecated Use {@link #getConnTimeout()} and {@link #getReqTimeout()}
instead.
* @return Timeout.
*/
+ @Deprecated
public int getTimeout() {
- return timeout;
+ return Math.max(connTimeout, reqTimeout);
Review Comment:
Let's return req timeout here
##########
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java:
##########
@@ -227,19 +230,55 @@ public ClientConfiguration setTcpNoDelay(boolean
tcpNoDelay) {
}
/**
+ * @deprecated Use {@link #getConnTimeout()} and {@link #getReqTimeout()}
instead.
* @return Send/receive timeout in milliseconds.
*/
+ @Deprecated
public int getTimeout() {
- return timeout;
+ return Math.max(connTimeout, reqTimeout);
}
/**
+ * @deprecated Use {@link #setConnTimeout(int)} and {@link
#setReqTimeout(int)} instead.
* @param timeout Send/receive timeout in milliseconds.
* @return {@code this} for chaining.
*/
+ @Deprecated
public ClientConfiguration setTimeout(int timeout) {
- this.timeout = timeout;
+ this.connTimeout = timeout;
+ this.reqTimeout = timeout;
+ return this;
+ }
+
+ /**
+ * @return Connection timeout in milliseconds. 0 means infinite.
+ */
+ public int getConnTimeout() {
Review Comment:
Do not use abbreviations for method names
##########
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java:
##########
@@ -57,8 +57,11 @@ public final class ClientConfiguration implements
Serializable {
/** @serial Tcp no delay. */
private boolean tcpNoDelay = true;
- /** @serial Timeout. 0 means infinite. */
- private int timeout;
+ /** @serial Connection timeout in milliseconds. 0 means infinite. */
+ private int connTimeout;
+
+ /** @serial Request timeout in milliseconds. 0 means infinite. */
+ private int reqTimeout;
Review Comment:
Which timeout is used for sending requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
