adityamukho commented on code in PR #7188:
URL: https://github.com/apache/ignite-3/pull/7188#discussion_r2609691778
##########
modules/api/src/main/java/org/apache/ignite/network/NetworkAddress.java:
##########
@@ -41,6 +41,14 @@ public class NetworkAddress {
* @param port Port.
*/
public NetworkAddress(String host, int port) {
+ if (host == null || host.isEmpty()) {
+ throw new IllegalArgumentException("Host address cannot be null or
empty");
+ }
+
+ if (port < 1024 || port > 65535) {
Review Comment:
You're right. Also, this change is somewhat out of scope and unrelated to
this PR, and so I have reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
